docs: Improve embedded tweet performance #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
cpcramer
commented
Oct 1, 2024
Comment on lines
5
to
9
| // Dynamically load the Twitter script after the component mounts | ||
| const script = document.createElement('script'); | ||
| script.src = 'https://platform.twitter.com/widgets.js'; | ||
| script.async = true; | ||
| document.body.appendChild(script); |
There was a problem hiding this comment.
Main update - loading the Twitter script once instead of 3 times.
There was a problem hiding this comment.
Should fix loading the widget javascript
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
approved these changes
Oct 1, 2024
cpcramer
commented
Oct 1, 2024
|
|
||
| useEffect(() => { | ||
| const script = document.createElement('script'); | ||
| script.src = 'https://platform.twitter.com/widgets.js'; |
There was a problem hiding this comment.
Only load the widget script once...was previously loading for each tweet
0xAlec
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?